use `traverse` instead of `overJust`

uber / queryparser

Parsing and analysis of Vertica, Hive, and Presto SQL.

MIT License

1.08k stars 147 forks source link

use `traverse` instead of `overJust` #24

Closed Fuuzetsu closed 6 years ago

Fuuzetsu commented 6 years ago

You have

module Data.Maybe.More where

overJust :: Applicative f => (t -> f a) -> Maybe t -> f (Maybe a)
overJust _ Nothing = pure Nothing
overJust f (Just x) = Just <$> f x

but this is exactly traverse for Maybe.

h4v0kh3l1 commented 6 years ago

So it is. Thanks @Fuuzetsu for pointing that out!

I doubt I'll have time this week to go through and clean it up, but this looks like a great issue for a first-time contributor.