search

uber / react-digraph

A library for creating directed graph editors
MIT License
2.63k stars 268 forks source link

Unmount React Components when removing elements from Dom #322

Open adamzapasnik opened 3 years ago

adamzapasnik commented 3 years ago

Resolves https://github.com/uber/react-digraph/issues/321

If the code doesn't meet your quality standards, then feel free to rewrite it on your own. I don't have much experience in working with js/react libs, so I'm afraid I won't be able to meet your requirements.

I tried to test it with my app via yarn link, but I couldn't make it work, heh... Also wanted to check it via /examples, but they are outdated, aren't they?

Let me know if there is anything I can do to fix it "asap".

EDIT: Now that I think about it, it's not a complete solution. React components (including zoom) should be also removed in componentWillUnmount I think?

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.