RFC Modernize repository

uber / react-vis

Data Visualization Components

https://uber.github.io/react-vis

MIT License

8.73k stars 835 forks source link

RFC Modernize repository #1316

Open chrisirhc opened 4 years ago

chrisirhc commented 4 years ago

[x] Use yarn workspaces https://github.com/uber/react-vis/pull/1317
[ ] Move into using hooks https://github.com/uber/react-vis/issues/1320 (and track performance while doing so)
[ ] Use context instead of copying props (need proposals/rfcs to evaluate different approaches)
[ ] Use project relative imports that are easier to distinguish (ie, ~/*)
[x] Clean up + Move to jest for unit tests https://github.com/uber/react-vis/issues/1328
[ ] Upgrade D3 (low-priority) https://github.com/uber/react-vis/issues/1330
[ ] Support React 17 #1356

From offline sync with @Xiot

reitlepax commented 4 years ago

I'm willing to try to convert some components to hooks, for instance I can make a PR to the modernize branch, sounds good ?

chrisirhc commented 4 years ago

I'm willing to try to convert some components to hooks, for instance I can make a PR to the modernize branch, sounds good ?

Yep, that sounds good. We may need to rebase it after #1317 .

@Xiot would that be easier or should we start with the yarn workspaces branch?

Xiot commented 4 years ago

Probably start with the yarn workspace branch. I can merge that into modernize once I clean it up.

thetylerreiff commented 4 years ago

Hey all, I would recommend starting with yarn workspace then we can dig into the rest. I’ll gladly implement hooks as needed 👍

I have experience with workspaces if that’s something you want me to look at or help out with.

Xiot commented 4 years ago

@reiff12 We've already started on moving over to yarn workspaces https://github.com/uber/react-vis/pull/1317 Moving to use workspaces was fairly simple. The fun part is updating the dependencies throughout. I almost have everything working, and its just mainly the website project that doesn't build due to ocular

chrisirhc commented 4 years ago

At this point, the docs generation is the main challenge before we can merge the workspaces PR. Though I think it's ok to merge it before we have it fully worked out, since the website build has been broken for a while now.

@ibgreen : what doc practices are you all following for your projects? Is there a repo that shows your latest docs practices? Perhaps we could leverage them here and it might be less work to migrate to that compared to rethinking how to generate docs here.

Separately, for folks interested in looking at the hooks conversion: how about putting up some RFCs/proposals on approaches for discussion via #1320?