uber / rides-ios-sdk

Uber Rides iOS SDK (beta)
https://developer.uber.com/docs
MIT License
374 stars 124 forks source link

Reduce scope of `UberAuthenticating` protocol #204

Closed edjiang closed 6 years ago

edjiang commented 6 years ago

Previously, the UberAuthenticating objects kept track of the authentication workflow, saved tokens to the Keychain, etc.

Since that behavior was moved into the LoginManager in #200, this change reduces the UberAuthenticating protocol to just two functions:

This allows us to match different forms of authentication (implicit, native, etc) with different ways of presenting it (deeplinks, SFAuthenticationSession, SFSafariViewController, and just Safari) a lot easier.

bobz commented 6 years ago

Unfortunate that github isn't picking up the renames here.