search

uber / rides-ios-sdk

Uber Rides iOS SDK (beta)
https://developer.uber.com/docs
MIT License
374 stars 124 forks source link

Fixed zero size login button #212

Closed edjiang closed 6 years ago

edjiang commented 6 years ago

By default, adding a LoginButton without sizing constraints to your view would make a 0x0 login button.

I noticed this while testing the README last week, but also publicly reported here.

This is because we were missing a sizeToFit() call. See the RideRequestButton, for instance.

https://github.com/uber/rides-ios-sdk/blob/master/source/UberRides/RideRequestButton.swift#L168

This will also be rebased against develop