search

uber / rides-ios-sdk

Uber Rides iOS SDK (beta)
https://developer.uber.com/docs
MIT License
374 stars 124 forks source link

HTTPMethod got exposed in 0.8 #216

Closed wenxin3262 closed 6 years ago

wenxin3262 commented 6 years ago

Didn't have the issue before but after the upgrade, I am getting Ambiguous context error since Alamofire has its own HTTPMethod class. I think UberSDK should mark HTTPMethod and related networking code as private classes.

edjiang commented 6 years ago

Thanks for the feedback. We marked it as public as part of the modularization effort in 0.8, since UberRides depends on UberCore.

Since it's not really intended to be consumed by the public, I think we can probably just namespace it for developer convenience.

In the meantime, you can use Alamofire.HTTPMethod and UberCore.HTTPMethod to distinguish between the classes.

edjiang commented 6 years ago

Fixed in 0.9!