search

uber / rides-ios-sdk

Uber Rides iOS SDK (beta)
https://developer.uber.com/docs
MIT License
374 stars 124 forks source link

Fixed a bug where the system dialog box: #222

Closed lhasiuk closed 6 years ago

lhasiuk commented 6 years ago

Fixed a bug where the system dialog box:

"" wants to open "Uber" Cancel / Open

would cause SSO to fail because the system dialog triggers the UIApplicationDidBecomeActive notification. The fix is to make sure that the notification is preceded by a UIApplicationWillEnterForeground notification, which happens only when the there's been a context switch to the Uber app.

Fixed a related bug where, if the user were to select Cancel in the system dialog box (above), the library would attempt to use fallback to a web view, when the correct handling would be to stop attempting to log in and return an error to the caller.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

edjiang commented 6 years ago

Thanks @lhasiuk! Let me take a look at this and get it merged for you :)

edjiang commented 6 years ago

Hey @lhasiuk, I have some changes that I'd like to push to your branch, before merging. They should fix the tests and add an additional test to verify this behavior. Could you please allow me to push to your branch?

https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

lhasiuk commented 6 years ago

@edjiang Allow edits from maintainers is already enabled.

edjiang commented 6 years ago

Published to Cocoapods, 0.8.1. Thanks so much for your help!

shahidgeek commented 5 years ago

Uber Android SDK Authentication issue for "User cancel login" Solved

https://github.com/uber/rides-ios-sdk/issues/90#issuecomment-459646713