uber / rides-ios-sdk

Uber Rides iOS SDK (beta)
https://developer.uber.com/docs
MIT License
374 stars 124 forks source link

.native login issue #227

Open nafetswirth opened 6 years ago

nafetswirth commented 6 years ago

The .native type login all of a sudden stopped working for us today.

We have recently requested the all_trips scope and got it granted. It worked fine for a day but now when we are trying to login it opens the Uber app and does nothing (no redirect no scope approval screen).

This has been working for us for the last 2 or 3 months so I was wondering if the scopes are the issue here or maybe the last Uber update.

SDK version is 0.9.0

Best, Stefan

edjiang commented 6 years ago

I can't reproduce this; have you tried force quitting the Uber app and re-opening it? Uber can get stuck in a state where the SSO dialog won't open; it's a known issue and will be addressed in the mid future.

nafetswirth commented 6 years ago

@edjiang Yes i tried that. I've had multiple people with the same problem apparently after updating the Uber app.

Uber version is v3.287.10003 if that helps

edjiang commented 6 years ago

Hm, I'm not able to reproduce even on 3.287.10003.

Is this the case for everyone using your app? Or just some? Is it only for your app? (Try building the sample app on master, for instance)

nafetswirth commented 6 years ago

The example app works fine but it uses the standard login button.

So i went ahead and tried the standard login button inside our app that had a custom one that uses the underlying LoginManager(loginType: .native).

Turns out the standard LoginButton works fine with the same settings (scopes, clientId etc) as our custom button.

Seems odd to me because as far as i can see the LoginButton just delegates to LoginManager

edjiang commented 6 years ago

Hm. Can you log the deeplink url being used for both cases? You can email me, edjiang@uber.com with more details.

theonetheycallneo commented 4 years ago

We are receiving an error from the Uber SSO

deeplink://error=jwt_creation_failure

Our auth url is:

uberauth://connect?client_id={REDACTED}&client_secret={REDACTED}&login_type=default&third_party_app_name=Freebird Rides Staging&callback_uri_string=freebird://uberSSO&scope=all_trips history places profile offline request request_receipt vouchers.redeem&sdk=ios&sdk_version=3.0.0

Has anyone had problems with this?

https://stackoverflow.com/questions/58868478/uber-sso-errors-with-jwt-creation-failture

RaytIgor commented 4 years ago

I am facing the same problem as @theonetheycallneo. I have reported the issue in details here: https://github.com/uber/rides-ios-sdk/issues/262

austinllach commented 4 years ago

@theonetheycallneo @RaytIgor anyone solve this yet?

RaytIgor commented 4 years ago

@austinllach no, nothing yet

arogal commented 4 years ago

We are currently investigating this issue. We'll update everyone with any findings ASAP.

On Tue, Nov 19, 2019, 7:20 AM Igor Rayt notifications@github.com wrote:

@austinllach https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_austinllach&d=DwMCaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=1hsyAcyXYdXfoRXqKFXyfg&m=Lui0Lx1QyGdXVb0wb6xWFB3XfvHm0k24O1P5weN5vFM&s=86a2Uy3vBx_M8Y2Yi0o1sow4agBVjO4mS9JhwfbG7B8&e= no, nothing yet

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_uber_rides-2Dios-2Dsdk_issues_227-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DABITDIF3VEQSC2EETVSXZC3QUP73VA5CNFSM4ETE6I62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEORTAI-23issuecomment-2D555555201&d=DwMCaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=1hsyAcyXYdXfoRXqKFXyfg&m=Lui0Lx1QyGdXVb0wb6xWFB3XfvHm0k24O1P5weN5vFM&s=XWPMl3ShL7PxLaafTjUNVlN8TbOxEG5bcjh6PNYqeL4&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABITDIFQLOBVD347Y3T2KPLQUP73VANCNFSM4ETE6I6Q&d=DwMCaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=1hsyAcyXYdXfoRXqKFXyfg&m=Lui0Lx1QyGdXVb0wb6xWFB3XfvHm0k24O1P5weN5vFM&s=vCkAxK-Hs8gSCblEq2XCN-YsdbeDuBT0DF-lK1nQfMw&e= .

RaytIgor commented 4 years ago

@austinllach did you manage to find a work around?

austinllach commented 4 years ago

@theonetheycallneo @RaytIgor my contacts told me Uber's backend was being fixed. Pull the latest sdk changes, and ~ Dec 3rd the Uber Rider app will be updated. Then this should be resolved.

RaytIgor commented 4 years ago

@austinllach thanks a lot for the update!