search

uber / rides-ios-sdk

Uber Rides iOS SDK (beta)
https://developer.uber.com/docs
MIT License
374 stars 124 forks source link

Making UI update of LoginButton happening on the Main Thread #228

Closed evisoup closed 6 years ago

evisoup commented 6 years ago

Currently, the text of the UILabel uberTitleLabel is not being updated on the main thread, resulting in the text not properly displayed on the screen in some cases.

I switched the operation to the main thread. Self is captured weak for better memory management.

Xcode warning: screen shot 2018-03-08 at 1 01 06 pm

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

edjiang commented 6 years ago

Thanks @evisoup! Sorry for taking a while to respond; this makes a lot of sense. Merging; will cut a release in a bit.