uber / rides-ios-sdk

Uber Rides iOS SDK (beta)
https://developer.uber.com/docs
MIT License
374 stars 124 forks source link

"Access to Information" page does not show up in Uber app, while doing native SSO authorisation #231

Closed avinmore closed 6 years ago

avinmore commented 6 years ago

Hello There, I have integrated rides-ios-sdk for SSO authorisation in my native iOS application, It is working fine until I launch Uber app and open left menu.

Here is the use case:

  1. Launched Uber application and open left menu in Uber app.
  2. Performed SSO authorisation from my native iOS application.

Result: Access to Information that is authorisation page does not show up, it just launches the Uber application.

Workaround: I have to kill Uber app and perform SSO again from my application, then it works.

Uber application version : v3.299.10002 Uber SDK version : 0.9.0 iOS version: 10.3.2 Deeplink: uberauth://connect?third_party_app_name=my-app-name&callback_uri_string=com.XXXX.YYYY://oauth/consumer&client_id=XXXXXXXXXXXXXX&scope=all_trips&sdk=ios&sdk_version=0.9.0

edjiang commented 6 years ago

Thanks for the report. We're aware of this bug, and have this in our backlog :) We'll keep you updated!

edjiang commented 6 years ago

This is fixed in iOS version 3.300.x; you'll see it released soon!

edjiang commented 6 years ago

How is your report on 3.299? Is that a typo? 3.299 isn't on the App Store yet.

SandroGrzicic commented 5 years ago

Are there any "states" within the Uber app for which a native SSO request is ignored? Specifically, the Uber app was in the background after a ride, with the ride feedback request at the bottom, and a native SSO request from our app didn't result in showing the "Access to Information" page - the Uber app went to the foreground and was showing the option to give feedback at the bottom. Going back to our app and then attempting native SSO again resulted in the same behaviour multiple times.

After restarting the Uber app, native SSO worked again normally (other than this issue, native SSO works fine on all of our test devices, we only spotted this problem today).

This is on the iPhone X (iOS 12.1) with Uber version v3.325.10003 and uber-rides SDK 0.10.

Thanks!