search

uber / rides-ios-sdk

Uber Rides iOS SDK (beta)
https://developer.uber.com/docs
MIT License
371 stars 123 forks source link

iOS 13 support... New release anytime? #263

Open austinllach opened 4 years ago

austinllach commented 4 years ago

Uber iOS Engineering,

My team has been having to patch the rides-ios-sdk for quite some time to get it to work.

Are there plans to update this sdk with a new release? Or should we begin transferring all uber related services to our API?

tellodaniel commented 4 years ago

+1

Igorsnaki commented 4 years ago

+1

wenxin3262 commented 4 years ago

+1 @austinllach do you mind to share the patch? Uber SSO stopped working and the patch I did for the last time is no longer working on iOS 13.2.3.

arogal commented 4 years ago

Hi all,

We are actively investigating this and will update this thread when we find anything.

Thanks, Adam

bijan-amirzada commented 4 years ago

+1 Seems like the authorization through the API is also broken on 13+

austinllach commented 4 years ago

@wenxin3262 that's the same issue we're facing now

arogal commented 4 years ago

We've identified a fix for iOS 13+ and will be making a backend change along with an SDK release.

Igorsnaki commented 4 years ago

We've identified a fix for iOS 13+ and will be making a backend change along with an SDK release.

Hello. Could you please provide any estimates when the issue will be fixed? As far as I see, 0.13 version just fix check sorce application issue, but login still not working.

I still receive: {my_redirect_url}/?error=jwt_creation_failure at any attempt to login to UBER. "The server was unable to understand your request." - error message

arogal commented 4 years ago

We've rolled out a fix. Can you please try updating your Uber rider app and verify which version you are on?

On Tue, Dec 10, 2019, 5:53 AM Igorsnaki notifications@github.com wrote:

We've identified a fix for iOS 13+ and will be making a backend change along with an SDK release.

Hello. Could you please provide any estimates when the issue will be fixed? As far as I see, 0.13 version just fix check sorce application issue, but login still not working.

I still receive: {my_redirect_url}/?error=jwt_creation_failure at any attempt to login to UBER. "The server was unable to understand your request." - error message

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_uber_rides-2Dios-2Dsdk_issues_263-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DABITDIA5HPHAI4KIIJZJF7DQX6NOTA5CNFSM4JOC5QQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGPJULI-23issuecomment-2D564042285&d=DwMCaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=1hsyAcyXYdXfoRXqKFXyfg&m=gDItq4YKSFn0eTOhtYPMsLyjQ1i6eq7gFlF08Nzj6sU&s=ih1X24HnMmDTg1Rt9_6jR7UYIKgB9eFvtJjpjwkr44Q&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABITDIEZLCF6U7A25ADUWOTQX6NOTANCNFSM4JOC5QQQ&d=DwMCaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=1hsyAcyXYdXfoRXqKFXyfg&m=gDItq4YKSFn0eTOhtYPMsLyjQ1i6eq7gFlF08Nzj6sU&s=RvKaUvGhzKC0lyiCRpf8oHnOwcJVgLiA7TogNBISur8&e= .

austinllach commented 4 years ago

@arogal everything works for our company now with Uber rider app v3.381.10002 and the latest uber sdk v.13

Thanks for the support.

Igorsnaki commented 4 years ago

We've rolled out a fix. Can you please try updating your Uber rider app and verify which version you are on? …

Sorry , I didn't catch, that I need to update Uber native app also.

I just checked and can confirm that issue fixed on uber sdk v. 0.13 + Uber native app v.3.382.10006

padsalanilay commented 4 years ago

Hi @arogal, I am facing a similar issue. My app gets redirect to the Uber app and right after that it again gets redirected back, and I receive "User canceled the login process" error. I have added code to AppDelegate and also have added required keys to info.plist I am using a sandbox and have enabled it in a delegate.

ios - 13.5 cocoa UberRides - 0.13

Thanks