uber / rides-ios-sdk

Uber Rides iOS SDK (beta)
https://developer.uber.com/docs
MIT License
371 stars 123 forks source link

Cleanup and relocate dependencies #301

Closed mohssenfathi closed 2 months ago

mohssenfathi commented 2 months ago

Summary

Deleting unused/legacy classes from the old SDK. Relocating common classes to core. Relocating Rides specific classes to UberRides.

Changes

The majority of code changes are file deletions and relocations. A few logic changes were required:

Scopes

A few classes (ApplicationLaunched, AsyncDispatcher, PlistParser) that were moved from UberAuth -> UberCore gained public scope.

RideRequestViewController

The LoginManager property was removed from this class and a TODO was added to support injecting access token identifier and keychain group. These will come in a later PR.

RidesClient + Token Refresh

A TODO was added to the token refresh method in Rides Client. This will be added once token refresh is implemented in UberAuth.