search

uber / rides-java-sdk

Uber Rides Java SDK (beta)
https://developer.uber.com/docs
MIT License
104 stars 57 forks source link

Allow to wiremock API responses instead of using sandbox #28

Open pjagielski opened 7 years ago

pjagielski commented 7 years ago

Motivation

We extensively use Rides API and have about 30 integration tests with various API interactions. When using sandbox our build took about 8 minutes to finish, so we decided to mock Rides API with WireMock. Now the build takes less than 3 minutes ;)

Details

Instead of setting Environment we added a baseUrl property which is used to build endpointHost if present.

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

tyvsmith commented 7 years ago

Thanks for the commits! I won't have time to full review until after Thanksgiving week, but then this will be on my radar to get reviewed and merged.

itstexter commented 7 years ago

Sorry about this, busy week has lead to still not getting to this, we'll look to get at this soon.

rompic commented 7 years ago

+1

tyvsmith commented 6 years ago

Getting back to this after a while away from this project. Change looks good but needs to be rebased.

pjagielski commented 6 years ago

Rebased ;)