uber / ringpop-go

Scalable, fault-tolerant application-layer sharding for Go applications
http://www.uber.com
MIT License
835 stars 83 forks source link

Fix leaking timer goroutines #186

Open andrewdeandrade opened 8 years ago

andrewdeandrade commented 8 years ago

This fixes two leaking goroutines from the ringpop timers. There is still one more leaking goroutine that I'm aware of in rcrowley/go-metrics:

https://github.com/rcrowley/go-metrics/blob/master/meter.go#L218-L225

That's a ticker that would also require a stop channel.

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.