search

uber / ringpop-go

Scalable, fault-tolerant application-layer sharding for Go applications
http://www.uber.com
MIT License
835 stars 83 forks source link

Generated rinpop adapter does not compile when there is service extension #210

Open chucknthem opened 7 years ago

chucknthem commented 7 years ago 
service Foo {
   string ping()
}

service Bar extends Foo {
}

The generated code fails with this error:

cannot use adapter (type *RingpopBarAdapter) as type TChanBar in return argument:
    *RingpopBarAdapter does not implement TChanBar (missing Ping method)

Examples of how tchannel-go thrift gen template handles it https://github.com/uber/tchannel-go/blob/dev/thrift/thrift-gen/tchannel-template.go#L55 https://github.com/uber/tchannel-go/blob/dev/thrift/thrift-gen/tchannel-template.go#L45

proflayton commented 7 years ago

I am also seeing the same problem. Can we prioritize this?