Closed andrewdeandrade closed 9 years ago
This PR adds most of the new rules in eslint 0.24.0 that are non-controversial or were already enforced in lint-trap but missing in uber/standard. A separate PR will be submitted for those rules that are deemed more controversial.
Rules that are now turned on:
no-catch-shadow
no-continue
no-div-regex
no-else-return
no-eq-null
no-extra-parens
no-inline-comments
no-mixed-requires
no-throw-literal
no-unexpected-multiline
no-unneeded-ternary
array-bracket-spacing
block-scoped-var
computed-property-spacing
dot-location
newline-after-var
object-curly-spacing
operator-linebreak
space-before-function-paren
@Raynos @lxe @mlmorg @johnmegahan @jcorbin @kriskowal
:+1: lgtm
Finished review.
lgtm.
This PR adds most of the new rules in eslint 0.24.0 that are non-controversial or were already enforced in lint-trap but missing in uber/standard. A separate PR will be submitted for those rules that are deemed more controversial.
Rules that are now turned on:
no-catch-shadow
no-continue
no-div-regex
no-else-return
no-eq-null
(probably a noop since we have strict equality required)no-extra-parens
no-inline-comments
(already in lint-trap)no-mixed-requires
(probably a noop since we require one var per line)no-throw-literal
no-unexpected-multiline
no-unneeded-ternary
array-bracket-spacing
(was already in lint-trap)block-scoped-var
computed-property-spacing
dot-location
(dot on property which is the most common style I've seen)newline-after-var
object-curly-spacing
(was already in lint-trap)operator-linebreak
(linebreaks go after infix operators)space-before-function-paren
@Raynos @lxe @mlmorg @johnmegahan @jcorbin @kriskowal