search

uber / standard

JavaScript Standard Style — One Style to Rule Them All
MIT License
70 stars 8 forks source link

Revert object-curly-spacing changes #30

Closed mlmorg closed 9 years ago

mlmorg commented 9 years ago

In lint-trap and standard (< v4), spacing bracket spacing was disallowed. In v4, it is now the opposite and causes errors in all existing applications. Assuming this is simply a bug, I am reverting that change in this PR.

@malandrew @Raynos

cain-wang commented 9 years ago

Thanks! This prevents me upgrading to standard 4.0.

Raynos commented 9 years ago

@mlmorg

I standard <4 the object-curly-spacing was set to 0.

I'm fine with a revert but let's revert to 0 rather then "never"

mlmorg commented 9 years ago

We had space-in-brackets set to never (https://github.com/uber/standard/blob/46470553937a701d2763c35e745ccc29e678f011/rc/.eslintrc.json#L318-L321) but that was replaced (since it was deprecated) by object-curly-spacing set to always.

Raynos commented 9 years ago

Oh I see; legit. #shippingit

Raynos commented 9 years ago

lgtm

andrewdeandrade commented 9 years ago

Will land tomorrow and publish a new version.