uber / standard

JavaScript Standard Style — One Style to Rule Them All
MIT License
70 stars 8 forks source link

indentation is not actually 2 spaces #49

Open vicapow opened 8 years ago

vicapow commented 8 years ago

When you clone a project that uses uber-standard and run the linter, it complains that indentation should be 4, not 2. see: https://github.com/uber/react-map-gl/pull/41

Looks like this is only working now because most uber engineers have an .editorconfig setup to be something, more or less like this.

# EditorConfig: http://editorconfig.org

root = true

[*]
indent_style = space
indent_size = 2
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

This should probably be as simple as changing: https://github.com/uber/standard/blob/master/rc/.eslintrc.json#L228 to be something like: https://github.com/feross/eslint-config-standard/blob/master/eslintrc.json#L38

I think copying that entire indent value might also fix: https://github.com/uber/standard/issues/46

Raynos commented 8 years ago

uber-standard uses 4 spaces.