Closed cinchurge closed 2 years ago
Merging #879 (65869b5) into dev (f45abb5) will decrease coverage by
0.06%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## dev #879 +/- ##
==========================================
- Coverage 88.80% 88.73% -0.07%
==========================================
Files 43 43
Lines 4439 4439
==========================================
- Hits 3942 3939 -3
- Misses 378 381 +3
Partials 119 119
Impacted Files | Coverage Δ | |
---|---|---|
relay.go | 86.11% <0.00%> (-1.29%) |
:arrow_down: |
peer.go | 93.52% <0.00%> (-0.36%) |
:arrow_down: |
connection.go | 85.68% <0.00%> (+0.92%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e21471f...65869b5. Read the comment docs.
Currently,
make test
bundles "vanilla" testing with frame leak checks, which re-runs all tests with frame leak checks enabled for some tests (currently all relay tests).This makes routine testing pretty painful, as each test run requires upwards of 10 minutes, slowing down development significantly.
This change improves the situation by
test_vanilla
target that runs all tests without any leak checkstest_relay_frame_leaks
target which tests ONLYrelay_test.go
with frame leak checks enabled. Frame leak checks are currently enabled only in that filemake test
to run the above in successionExcept for scoping down the frame leak tests, the behavior of
make test
is intentionally maintained since we still run all tests in CI.