search

uber / tchannel-go

Go implementation of a multiplexing and framing protocol for RPC calls
http://uber.github.io/tchannel/
MIT License
490 stars 84 forks source link

Release 1.31.1 #884

Closed DheerendraRathor closed 2 years ago

DheerendraRathor commented 2 years ago

Create new release v1.31.1 with

This is created against tag v1.31.0, which is different from release shown on Github with 1.31.0. Tagged v1.31.0 doesn't contain vendored apache thrift changes and this is considered as latest version by go get.

codecov[bot] commented 2 years ago

Codecov Report

Merging #884 (0209d6f) into v1.31.1 (d84cd5f) will decrease coverage by 0.47%. The diff coverage is n/a.

:exclamation: Current head 0209d6f differs from pull request most recent head e2d736a. Consider uploading reports for the commit e2d736a to get more accurate results

@@             Coverage Diff             @@
##           v1.31.1     #884      +/-   ##
===========================================
- Coverage    89.20%   88.73%   -0.48%     
===========================================
  Files           43       43              
  Lines         4439     4439              
===========================================
- Hits          3960     3939      -21     
- Misses         361      381      +20     
- Partials       118      119       +1
Impacted Files Coverage Δ
connection.go 84.98% <0.00%> (-4.39%) :arrow_down:
channel.go 87.85% <0.00%> (-1.30%) :arrow_down:
outbound.go 88.30% <0.00%> (-0.59%) :arrow_down:
preinit_connection.go 94.28% <0.00%> (+1.42%) :arrow_up:
sockio_unix.go 100.00% <0.00%> (+15.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d84cd5f...e2d736a. Read the comment docs.

cinchurge commented 2 years ago

can you split the code change off of the release changes? see https://github.com/uber/tchannel-go/blob/dev/RELEASE.md