uber / tchannel-go

Go implementation of a multiplexing and framing protocol for RPC calls
http://uber.github.io/tchannel/
MIT License
490 stars 84 forks source link

Emit the error code and type to the tracing span for inbound calls #903

Closed deepanshumehndiratta closed 1 year ago

deepanshumehndiratta commented 1 year ago

Changelog

  1. Emit the error code and type to the tracing span for inbound calls

Description

This change adds the error type and code (for system errors) to the tracing spans for inbound requests.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 71.79% and project coverage change: +0.10% :tada:

Comparison is base (0c11cc2) 88.78% compared to head (f3409ca) 88.89%. Report is 5 commits behind head on dev.

:exclamation: Current head f3409ca differs from pull request most recent head 51344aa. Consider uploading reports for the commit 51344aa to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #903 +/- ## ========================================== + Coverage 88.78% 88.89% +0.10% ========================================== Files 43 43 Lines 4440 4510 +70 ========================================== + Hits 3942 4009 +67 Misses 379 379 - Partials 119 122 +3 ``` | [Files Changed](https://app.codecov.io/gh/uber/tchannel-go/pull/903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [outbound.go](https://app.codecov.io/gh/uber/tchannel-go/pull/903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-b3V0Ym91bmQuZ28=) | `87.86% <33.33%> (+0.72%)` | :arrow_up: | | [messages.go](https://app.codecov.io/gh/uber/tchannel-go/pull/903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-bWVzc2FnZXMuZ28=) | `91.58% <50.00%> (-6.27%)` | :arrow_down: | | [inbound.go](https://app.codecov.io/gh/uber/tchannel-go/pull/903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-aW5ib3VuZC5nbw==) | `79.51% <61.53%> (-2.88%)` | :arrow_down: | | [mex.go](https://app.codecov.io/gh/uber/tchannel-go/pull/903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-bWV4Lmdv) | `75.42% <76.00%> (+2.91%)` | :arrow_up: | | [connection.go](https://app.codecov.io/gh/uber/tchannel-go/pull/903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29ubmVjdGlvbi5nbw==) | `88.39% <88.88%> (+3.40%)` | :arrow_up: | | [relay.go](https://app.codecov.io/gh/uber/tchannel-go/pull/903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-cmVsYXkuZ28=) | `85.77% <100.00%> (+0.06%)` | :arrow_up: | | [relay\_messages.go](https://app.codecov.io/gh/uber/tchannel-go/pull/903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-cmVsYXlfbWVzc2FnZXMuZ28=) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/uber/tchannel-go/pull/903/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.