search

uber / tchannel-go

Go implementation of a multiplexing and framing protocol for RPC calls
http://uber.github.io/tchannel/
MIT License
491 stars 84 forks source link

Add unit tests for emitting error code/type in tracing #904

Closed deepanshumehndiratta closed 1 year ago

deepanshumehndiratta commented 1 year ago

Add unit tests as a followup to https://github.com/uber/tchannel-go/pull/903/files

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (628e1b3) 88.86% compared to head (9477e82) 89.11%.

:exclamation: Current head 9477e82 differs from pull request most recent head 5c74b7f. Consider uploading reports for the commit 5c74b7f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #904 +/- ## ========================================== + Coverage 88.86% 89.11% +0.24% ========================================== Files 43 43 Lines 4510 4510 ========================================== + Hits 4008 4019 +11 + Misses 383 373 -10 + Partials 119 118 -1 ``` | [Files](https://app.codecov.io/gh/uber/tchannel-go/pull/904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [inbound.go](https://app.codecov.io/gh/uber/tchannel-go/pull/904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-aW5ib3VuZC5nbw==) | `84.39% <100.00%> (+3.41%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/uber/tchannel-go/pull/904/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.