search

uber / tchannel-go

Go implementation of a multiplexing and framing protocol for RPC calls
http://uber.github.io/tchannel/
MIT License
491 stars 84 forks source link

Fix unknown error type in span tag rpc.tchannel.system_error_code #907

Closed deepanshumehndiratta closed 1 year ago

deepanshumehndiratta commented 1 year ago

This change fixes the issue with an unknown error type being tagged in the tracing span for system errors. It also abstracts out setting the span tag to a different method which is called for both system and application errors

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6f3bd01) 88.93% compared to head (af4cd76) 89.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #907 +/- ## ========================================== + Coverage 88.93% 89.23% +0.30% ========================================== Files 43 43 Lines 4510 4515 +5 ========================================== + Hits 4011 4029 +18 + Misses 379 371 -8 + Partials 120 115 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

deepanshumehndiratta commented 1 year ago

the change looks ok, but can please add an end-to-end test? probably follow something like TestThriftTracingPropagation

Addressed with e2e tests