search

uber / tchannel-go

Go implementation of a multiplexing and framing protocol for RPC calls
http://uber.github.io/tchannel/
MIT License
490 stars 84 forks source link

Replace go.uber.org/atomic with sync/atomic #910

Open serprex opened 11 months ago

serprex commented 11 months ago

go 1.19 introduced atomic types https://tip.golang.org/doc/go1.19#atomic_types

Indirect dependency remains through multierr, but multierr recently dropped its go.uber.org/atomic dependency: https://github.com/uber-go/multierr/pull/72

CLAassistant commented 11 months ago

CLA assistant check
All committers have signed the CLA.

rabbbit commented 11 months ago

thanks for the contribution!

Out of curiosity, are you using this library anywhere?

serprex commented 11 months ago

It's a transitive dependency through https://temporal.io, which https://peerdb.io (data movement product) is built on top of Created https://github.com/temporalio/temporal/pull/5278 & https://github.com/temporalio/sdk-go/pull/1344 alongside this to hopefully get one line removed from our go.mod eventually

serprex commented 8 months ago

@rabbbit who's the decision maker for merging?

cinchurge commented 5 months ago

@rabbbit who's the decision maker for merging?

sorry for the lack of movement on this. the service mesh team at Uber is currently the de facto maintainers of this repo. can you shed light on how you're using tchannel-go?

serprex commented 5 months ago

@rabbbit who's the decision maker for merging?

sorry for the lack of movement on this. the service mesh team at Uber is currently the de facto maintainers of this repo. can you shed light on how you're using tchannel-go?

rely on it via temporal