search

uber / tchannel-go

Go implementation of a multiplexing and framing protocol for RPC calls
http://uber.github.io/tchannel/
MIT License
485 stars 82 forks source link

Expose `inbound.cancels.{requested,honored}` metrics #912

Closed vpranckaitis closed 8 months ago

vpranckaitis commented 9 months ago

This commit adds inbound.cancels.requested and inbound.cancels.honored metrics. The documentation mentions these metrics, but they were not yet implemented.

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

vpranckaitis commented 9 months ago

cc: @prashantv

vpranckaitis commented 9 months ago

Note that I couldn't run all the tests locally, because of the missing thrift-v1.0.0-dev/thrift-1-darwin-arm64.tar.gz binary for M1 Mac:

> make test 

<...>

scripts/install-thrift.sh /Users/vilius/go/src/github.com/vpranckaitis/tchannel-go/.bin
--2024-01-17 09:25:27--  https://github.com/uber/tchannel-go/releases/download/thrift-v1.0.0-dev/thrift-1-darwin-arm64.tar.gz
Resolving github.com (github.com)... 140.82.121.4
Connecting to github.com (github.com)|140.82.121.4|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-01-17 09:25:27 ERROR 404: Not Found.
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7576b14) 89.25% compared to head (e39a740) 89.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #912 +/- ## ========================================== - Coverage 89.25% 89.19% -0.07% ========================================== Files 43 43 Lines 4515 4517 +2 ========================================== - Hits 4030 4029 -1 + Misses 370 369 -1 - Partials 115 119 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cinchurge commented 8 months ago

bump?

vpranckaitis commented 8 months ago

@cinchurge there was a Lint failure due to missing comment for a method. I've added it in https://github.com/uber/tchannel-go/pull/912/commits/e39a740978f958cbc7b2012edc4a27ec7bbde8d5, need to rerun the CI.