search

uber / tchannel-go

Go implementation of a multiplexing and framing protocol for RPC calls
http://uber.github.io/tchannel/
MIT License
490 stars 84 forks source link

Fix protocol and add test #916

Closed zhiyipanuber closed 7 months ago

zhiyipanuber commented 7 months ago

For Skip(), if no type is recognized in switch statement, the function returns nil before. This PR fixed it to return an error.

This PR also adds a test for protocol, which follows apache thrift library.

The original fix already existed in upstream

cinchurge commented 7 months ago

synced offline with @AllenLuUber - looks like we're stuck with this version of apache thrift for the long haul :( can you please verify the correctness with full end-to-end testing? I'd like to reduce back and forth-ing for these changes.

zhiyipanuber commented 7 months ago

end to end testing will be done by @vldmit