search

uber / tchannel-go

Go implementation of a multiplexing and framing protocol for RPC calls
http://uber.github.io/tchannel/
MIT License
490 stars 84 forks source link

fix getSysConn to work with TLS connections #918

Closed DheerendraRathor closed 7 months ago

DheerendraRathor commented 7 months ago

tls.Conn by default doesn't implement syscall.Conn and hence tchannel emits onnection does not implement SyscallConn. log a lot.

Since go 1.18, tls.Conn exposes method NetConn() to expose raw underlying TCP connection. This is used for getting the syscall.Conn.

cinchurge commented 7 months ago

can you rebase off of #919 and push again?