Closed blampe closed 8 years ago
@junchaowu any pointers for how to release a new version of this?
cc @abhinav @prashantv @nikunjgit
good to go. The release process will take a long process since the release people need to get authorization from the central maven. If you are in hurry, just land the diff. I will release for you.
lgtm with nits
:shipit:
Resolves #137.
Java's iteration order for network interfaces looks reversed from Go. Here's Go's
ListenIP
with some logging added:And here's Java:
This PR mimics the Go implementation but prefers the last-seen match instead of the first-seen to account for this reverse ordering. The existing Java implementation had some other differences from Go (wasn't checking if the interface was up, for example) and so I feel more comfortable just copying Go since we know that works well.
I've confirmed locally that with this change Java will listen on the same IP as Go.