search

uber / tchannel-java

A Java implementation of the TChannel protocol.
MIT License
134 stars 65 forks source link

Fix potential leaks in RequestRouter #175

Closed yborovikov closed 7 years ago

yborovikov commented 7 years ago

Fix potential leaks in RequestRouter; fix a leak in HyperbahnClientTest; fix a leak in HyperbahnExample.

codecov-io commented 7 years ago

Codecov Report

Merging #175 into master will increase coverage by 0.26%. The diff coverage is 53.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #175      +/-   ##
============================================
+ Coverage     72.75%   73.01%   +0.26%     
- Complexity        9       10       +1     
============================================
  Files            87       87              
  Lines          2690     2679      -11     
  Branches        226      226              
============================================
- Hits           1957     1956       -1     
+ Misses          596      587       -9     
+ Partials        137      136       -1
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/com/uber/tchannel/api/TChannel.java 76.42% <ø> (-0.2%) 0 <0> (ø)
...java/com/uber/tchannel/handlers/RequestRouter.java 65.38% <53.33%> (-1.29%) 0 <0> (ø)
...rc/main/java/com/uber/tchannel/api/SubChannel.java 77.77% <0%> (+1.85%) 0% <0%> (ø) :arrow_down:
...m/uber/tchannel/hyperbahn/api/HyperbahnClient.java 62.16% <0%> (+8.1%) 7% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b1537f...33f7579. Read the comment docs.

yborovikov commented 7 years ago

@ashopov, thank you for reviewing the changes! i'm going to merge the PR in about half an hour (unless there's other feedback to address).