uber / tchannel-java

A Java implementation of the TChannel protocol.
MIT License
134 stars 65 forks source link

Concurrency fixes #183

Closed alshopov closed 6 years ago

alshopov commented 7 years ago

This batch is trickier.

codecov-io commented 7 years ago

Codecov Report

Merging #183 into master will increase coverage by 0.36%. The diff coverage is 63.49%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #183      +/-   ##
============================================
+ Coverage     70.98%   71.35%   +0.36%     
  Complexity       10       10              
============================================
  Files            87       87              
  Lines          2630     2653      +23     
  Branches        311      314       +3     
============================================
+ Hits           1867     1893      +26     
- Misses          543      544       +1     
+ Partials        220      216       -4
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/uber/tchannel/api/SubChannel.java 77.88% <100%> (+0.96%) 0 <0> (ø) :arrow_down:
...in/java/com/uber/tchannel/channels/Connection.java 62.5% <62.9%> (+0.77%) 0 <0> (ø) :arrow_down:
...ava/com/uber/tchannel/handlers/ResponseRouter.java 80.45% <0%> (+3.44%) 0% <0%> (ø) :arrow_down:
...java/com/uber/tchannel/handlers/RequestRouter.java 73.07% <0%> (+3.84%) 0% <0%> (ø) :arrow_down:
...a/com/uber/tchannel/channels/ChannelRegistrar.java 100% <0%> (+23.07%) 0% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77032af...4e7ac1e. Read the comment docs.