search

uber / tchannel-java

A Java implementation of the TChannel protocol.
MIT License
134 stars 65 forks source link

Fix potential request native memory leak in RequestRouter#channelRead0 #204

Closed denyska closed 4 years ago

denyska commented 4 years ago

Fix potential request native memory leak if RequestRouter#channelRead0 can't send BadRequest back

codecov[bot] commented 4 years ago

Codecov Report

Merging #204 into master will increase coverage by 0.19%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
+ Coverage     72.18%   72.36%   +0.19%     
  Complexity       10       10              
============================================
  Files            87       87              
  Lines          2674     2674              
  Branches        325      325              
============================================
+ Hits           1930     1935       +5     
+ Misses          520      517       -3     
+ Partials        224      222       -2
Impacted Files Coverage Δ Complexity Δ
...main/java/com/uber/tchannel/frames/ErrorFrame.java 80.56% <100%> (ø) 0 <0> (ø) :arrow_down:
...java/com/uber/tchannel/handlers/RequestRouter.java 76.15% <0%> (+1.83%) 0% <0%> (ø) :arrow_down:
...ava/com/uber/tchannel/handlers/ResponseRouter.java 80.23% <0%> (+3.49%) 0% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3530ca...d4615d8. Read the comment docs.