uber / tchannel-java

A Java implementation of the TChannel protocol.
MIT License
134 stars 65 forks source link

Make release() methods safe to use #215

Closed denyska closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #215 into master will increase coverage by 0.07%. The diff coverage is 89.13%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #215      +/-   ##
============================================
+ Coverage      73.4%   73.47%   +0.07%     
  Complexity       10       10              
============================================
  Files            87       87              
  Lines          2767     2801      +34     
  Branches        348      355       +7     
============================================
+ Hits           2031     2058      +27     
- Misses          510      515       +5     
- Partials        226      228       +2
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/uber/tchannel/messages/Request.java 76.02% <100%> (+2.48%) 0 <0> (ø) :arrow_down:
...main/java/com/uber/tchannel/frames/ErrorFrame.java 80.95% <66.67%> (-1.55%) 0 <0> (ø)
...main/java/com/uber/tchannel/messages/Response.java 69.42% <80.95%> (+0.85%) 0 <0> (ø) :arrow_down:
...java/com/uber/tchannel/handlers/RequestRouter.java 72.48% <0%> (-1.83%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18b6586...90135d3. Read the comment docs.

yoxule commented 4 years ago

LGTM