search

uber / tchannel-java

A Java implementation of the TChannel protocol.
MIT License
134 stars 65 forks source link

Tag span with error = true in case of ResponseCode.Error #223

Closed chornyi closed 4 years ago

chornyi commented 4 years ago

This would help with Thrift exceptions which are returned in the body and treated as successes.

I could not write a test due to https://github.com/uber/tchannel-java/pull/220#issuecomment-607660999

codecov[bot] commented 4 years ago

Codecov Report

Merging #223 into master will decrease coverage by 0.32%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #223      +/-   ##
============================================
- Coverage     75.04%   74.73%   -0.32%     
  Complexity       11       11              
============================================
  Files            88       88              
  Lines          2929     2932       +3     
  Branches        375      376       +1     
============================================
- Hits           2198     2191       -7     
- Misses          503      509       +6     
- Partials        228      232       +4
Impacted Files Coverage Δ Complexity Δ
...java/com/uber/tchannel/handlers/RequestRouter.java 75.59% <0.00%> (-5.05%) 0.00 <0.00> (ø)
...ava/com/uber/tchannel/handlers/ResponseRouter.java 76.14% <0.00%> (-3.41%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f616b9...e207ece. Read the comment docs.

denyska commented 4 years ago

LGTM