search

uber / tchannel-node

MIT License
203 stars 40 forks source link

Using host names as well as IPv4 addresses #327

Open yhorbachov opened 8 years ago

yhorbachov commented 8 years ago

Right now tchannel accepts only IPv4 addresses to create socket. tchannel uses standard node 'net' module which accepts host names and IPv4 addresses. I believe we should allow users use any format which they want.

Raynos commented 8 years ago

That doesn't actually work due to cross-language compatibility and init headers.

An IP is expected, we could resolve the hostname for you... but you might as well just give us an IP.

However, tcurl should support this.

prashantv commented 8 years ago

Yep, I filed an issue on tcurl a while ago, https://github.com/uber/tcurl/issues/125

Agree that it should be done outside of tchannel-node.

Choongkyu commented 3 years ago

related to this, how would we allow for 0.0.0.0? it looks like this can be enabled if allowEmphemeral(sic) is true, but I'm not seeing a way to set this to be true from the user. I'm having trouble with connections being refused when trying to call across pods using the cluster ip. Thanks!