uber / tchannel-node

MIT License
203 stars 40 forks source link

timeout should hold until last byte #328

Closed Raynos closed 8 years ago

Raynos commented 8 years ago

We've had an issue with the rt-msg service in production where they were seeing multi-minute latencies, probably because the timeout measure the time until the first call response frame, not the last.

We had previously supported streaming by making the timeout behave until the first call response frame.

However, this causes issues for people that encounter fragmented call responses.

Since we have barely any streaming customers we should recommend that people who use streaming and want timeout until first response frame simply set a very large timeout and a secondary custom timeout until the first response.

r: @ssyang @jcorbin @kriskowal

jcorbin commented 8 years ago

Sounds sensible, we can modify with an optional header as needed when needed.

syyang commented 8 years ago

lgtm

Raynos commented 8 years ago

Published 3.8.0