search

uber / tchannel-node

MIT License
203 stars 40 forks source link

request: checkTimeout() after identified #341

Closed Raynos closed 8 years ago

Raynos commented 8 years ago

We need to do another checkTimeout() after the request is identified to double check that we did not consume our request budget in the connection init handshake.

We also need to update the elapsed time so that when we make our outbound request we set a proper ttl-elapsed timeout on the per attempt request.

r: @zhijin @syyang

syyang commented 8 years ago

could we add a unit test please?

zhijinli commented 8 years ago

LGTM, thanks Jake!

Raynos commented 8 years ago

Now with tests.

syyang commented 8 years ago

lgmt. thanks!

syyang commented 8 years ago

thanks!

blampe commented 7 years ago

I the future please update the changelog for changes like this.