search

uber / tchannel-node

MIT License
203 stars 40 forks source link

Node 10 Support #355

Open lxe opened 6 years ago

lxe commented 6 years ago

tchannel-node fails to build on Node 10 Stable due to farmhash 1.1.0 dependency

Raynos commented 6 years ago

open an issue on farmhash.

Raynos commented 6 years ago

farmhash @ latest supports node10 but it probably does not support node0.10.32 ; we may need conditional dependencies based on node versions.

Raynos commented 6 years ago

since tchannel is in maintenance mode ; it makes sense to have a branch with node10.0 support and published as a seperate version number; maybe 3.9.12-node10-support

ajbogh commented 5 years ago

356 should fix this issue.

Edit: My mistake, #356 does not fix this.

ajbogh commented 5 years ago

Node 0.10.0 works as long as a couple of flags are defined with the right values. The error with farmhash stems from the Mac version, and a lack of the utility class for farmhash's header file.

Use flags with npm rebuild (replace rebuild with install if desired):

CXXFLAGS="-mmacosx-version-min=10.9" LDFLAGS="-mmacosx-version-min=10.9" npm rebuild

To be clear, this fixes Node 0.10.0, which is not the same as Node 10. Node 10's fix is in #356.