Add non-streaming option for forwardToTChannel in as-http

uber / tchannel

network multiplexing and framing protocol for RPC

MIT License

1.15k stars 129 forks source link

Add non-streaming option for forwardToTChannel in as-http #1259

Closed anson627 closed 9 years ago

anson627 commented 9 years ago

As discussed, leave options - streamed to forwardToTChannel caller instead of force streaming, so that tchannel can retry by turning off request streaming. r: @Raynos @jcorbin @ShanniLi cc: @vipulaneja

jcorbin commented 9 years ago

rebase on latest master to fix the jshint failure

anson627 commented 9 years ago

will do.

jcorbin commented 9 years ago

lgtm; especially since it's tested

anson627 commented 9 years ago

@jcorbin now lbpool version tests are exercising non-streaming path (both request and response), while non-lbpool version tests are on the streaming path. I will keep in mind about adding more tests.