search

uber / tchannel

network multiplexing and framing protocol for RPC
MIT License
1.15k stars 129 forks source link

go: Simplify Meta service endpoint registration #1288

Closed prashantv closed 8 years ago

prashantv commented 8 years ago

Design interface for services to easily register a Meta endpoint - they should only need to specify a function that returns a HealthResult.

xinlaini commented 8 years ago

+1, ideally, the thrift service implementer should be able to opt-out explicit health check handling by allowing the default handler to return OK.

IMO TChannel library should provide a default implementation of meta endpoints like health check. If the thrift service wants, they can provide an optional handler to override the default behavior, but they shouldn't be burdened with implementing the meta endpoints.

Raynos commented 8 years ago

This is implemented in node. ( https://github.com/uber/tchannel/blob/master/node/as/thrift.js#L63-L71 ).

We should also get this implemented in python.