Closed jc-fireball closed 9 years ago
Is there any plan to add one for Python/tornado?
2015年9月10日星期四,junchaowu notifications@github.com 写道:
@prashantv https://github.com/prashantv
You can view, comment on, or merge this pull request online at:
https://github.com/uber/tchannel/pull/1302 Commit Summary
- add default implementation of meta health endpoint
File Changes
- A golang/thrift/gen-go/meta/constants.go https://github.com/uber/tchannel/pull/1302/files#diff-0 (18)
- A golang/thrift/gen-go/meta/meta.go https://github.com/uber/tchannel/pull/1302/files#diff-1 (354)
- A golang/thrift/gen-go/meta/ttypes.go https://github.com/uber/tchannel/pull/1302/files#diff-2 (150)
- A golang/thrift/health.go https://github.com/uber/tchannel/pull/1302/files#diff-3 (30)
- A golang/thrift/health_test.go https://github.com/uber/tchannel/pull/1302/files#diff-4 (87)
- A golang/thrift/meta.thrift https://github.com/uber/tchannel/pull/1302/files#diff-5 (8)
- M golang/thrift/server.go https://github.com/uber/tchannel/pull/1302/files#diff-6 (27)
- A golang/thrift/tchan-meta.go https://github.com/uber/tchannel/pull/1302/files#diff-7 (82)
Patch Links:
— Reply to this email directly or view it on GitHub https://github.com/uber/tchannel/pull/1302.
-Ping
I will add it immediately.
lgtm, thanks for addressing all my feedback!
Fixes #1288
@prashantv