uber / tchannel

network multiplexing and framing protocol for RPC
MIT License
1.15k stars 129 forks source link

Tchannel is broke if applications do not install the thrift package #1315

Closed HelloGrayson closed 8 years ago

HelloGrayson commented 8 years ago

Even though my application never interacts with thrift directly, tchannel still blows up because it imports thrift in the health endpoint, and probably zipkin. This makes no sense... we need to either:

A.) Add thrift to setup_requires as long as setup requires thrift B.) Remove dependency on thrift entirely using thriftrw

HelloGrayson commented 8 years ago

wrong repo :\