Fix hostports tests to work with hyperbahn

uber / tchannel

network multiplexing and framing protocol for RPC

MIT License

1.15k stars 129 forks source link

Closed Raynos closed 9 years ago

Raynos commented 9 years ago

The hyperbahn cluster is slightly different. This gets the tests to pass from Hyperbahn itself

r: @jcorbin @rf @shannili

kriskowal commented 9 years ago

This screams getOrCreateSubChannel or simply getChannel with the rest implied. cc @jcorbin

jcorbin commented 9 years ago

yes please, let's add a 'getOrMake' (or s/make/create/ to taste).

ShanniLi commented 9 years ago

+1 for getOrMake. However, it feels optional for this diff.

lgtm.

Raynos commented 9 years ago

Disagree with getOrMake.

This is just a temporary mess because two versions of TestCluster.