PreferOutgoing.getScore should not create new outgoing connections; otherwise, it gets into race condition that ends up creating multiple out connections. That's why we observed 4x connection increase instead of 2x in Ringpop. On the other hand, it is not necessary anymore.
r @Raynos @kriskowal @anson627 cc @jcorbin
PreferOutgoing.getScore should not create new outgoing connections; otherwise, it gets into race condition that ends up creating multiple out connections. That's why we observed 4x connection increase instead of 2x in Ringpop. On the other hand, it is not necessary anymore.