search

uber / tchannel

network multiplexing and framing protocol for RPC
MIT License
1.15k stars 129 forks source link

PreferOutgoing.getScore should not create new outgoing connections #1331

Closed ShanniLi closed 8 years ago

ShanniLi commented 8 years ago

r @Raynos @kriskowal @anson627 cc @jcorbin

split from #1326 PreferOutgoing.getScore should not create new outgoing connections; otherwise, it gets into race condition that ends up creating multiple out connections. That's why we observed 4x connection increase instead of 2x in Ringpop. On the other hand, it is not necessary anymore.

anson627 commented 8 years ago

:+1:

ShanniLi commented 8 years ago

no, it should still work for the service channels. That's the whole point of removing it. I don't think it is necessary anymore. :)