Closed ShanniLi closed 8 years ago
As I mentioned earlier, can we please think about the interface that is appropriate here
map<string,string>
is a lot more future proof for multiple Thrift file services than string
struct
We can always have oneThriftIdl
and manyThriftIdl
Or we can fix it right now.
Let's fix it now, it's not hard to make a new struct with a map.
Cool let's fix it.
Meta is implemented per service, right?
The map is to future proof for import statements.
There is a single Meta
service for each Hyperbahn service. One hyperbahn service can expose multiple Thrift services though.
We also may have multiple Thrift files due to imports.
I see. Makes sense.
So, something like the following? struct ThriftIDLs { 1: required map<string,string> idls }
ThriftIDLs thriftIDL()
yep, I think the map should be map<string, string> idls
, but I think that's good enough for now
And we should add a comment for the map explaining what idls is (map from filename -> contents)
@ShanniLi
We need also 2: required entryPoint
to tell tcurl which file is the root that imports the others. Otherwise hacks
@Raynos fixed.
lgtm
r @prashantv @Raynos @junchaowu cc @blampe
@Raynos suggested us to move forward implementing a default handler for thriftIDL ... Node example is here: #1332