search

uber / tchannel

network multiplexing and framing protocol for RPC
MIT License
1.15k stars 129 forks source link

subChannel should be able to set peer preference #1339

Closed ShanniLi closed 8 years ago

ShanniLi commented 8 years ago

r @jcorbin @Raynos @kriskowal @anson627

anson627 commented 8 years ago

:+1:

kriskowal commented 8 years ago

review feedback is advisory. please ensure that @jcorbin weighs in.

Raynos commented 8 years ago

Discussed with @jcorbin out of band.

Decision was to not touch the heap and make each peer have only one preference.

Instead we want to update ServiceProxy and HyperbahnClient to set the correct preference at "peer creation time". We may need some extra args to makeSubChannel to pass preference through to the createPeer() call.

ShanniLi commented 8 years ago

moved to #1348