uber / tchannel

network multiplexing and framing protocol for RPC
MIT License
1.15k stars 129 forks source link

Hyperbahn unadvertise should not return error when it succeeds #1355

Closed anson627 closed 9 years ago

anson627 commented 9 years ago

Most of time remote socket closes immediately after unadvertise request is made, and shows up as a reset error, which actually means success.

@ShanniLi @Raynos @jcorbin

ShanniLi commented 9 years ago

lgtm

Raynos commented 9 years ago

This PR will need to be rebase on github.com/uber/tchannel-node