test: fix addrinuse flap

uber / tchannel

network multiplexing and framing protocol for RPC

MIT License

1.15k stars 129 forks source link

Closed rf closed 8 years ago

rf commented 8 years ago

@Raynos

Raynos commented 8 years ago

This is not enough.

We also have to fix TestCluster.

Raynos commented 8 years ago

Two things:

config.get() should only be called in constructor.
Let's not confuse Callback vs OnceListener functions. OnceListener functions are part of ReadySignal. We should handle errors at the right places and consistently name functions with onFoo vs foo where the former does not take an err and the latter does.

We should also always explicitly call cb(null).

Raynos commented 8 years ago

lgtm if passed.