search

uber / tchannel

network multiplexing and framing protocol for RPC
MIT License
1.15k stars 129 forks source link

Add java namespace to meta.thrift #1422

Open groz opened 6 years ago

groz commented 6 years ago

Problem

The classes generated for this file in Java by thrift compiler are currently put in default package, making them unusable from any other Java package.

This also means that any other thrift files that include this one, but declare a java namespace will have their thrift compilation successful, error will only be surfaced by Java compiler when those thrift files are used in Java project making chain of updates very costly.

One example of a workaround is in separate copy of this file in Java tchannel library.

Backwards compatibility concerns

I don't expect this diff breaking anything because the generated files could only be referenced from default package and that is not a widely spread practice in Java to begin with. However, repos that commit generated files in the artifacts will have a lot of their code regenerated.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.