uber / uReplicator

Improvement of Apache Kafka Mirrormaker
Apache License 2.0
917 stars 199 forks source link

producer.properties is out of date #199

Closed rantav closed 5 years ago

rantav commented 5 years ago

Looking at https://github.com/uber/uReplicator/blob/master/config/producer.properties I see some properties that are no longer supported by the producer and warnings in the log:

From the worker's log:

[2019-01-25 06:47:17,217] WARN The configuration 'batch.num.messages' was supplied but isn't a known config. (org.apache.kafka.clients.producer.ProducerConfig:287)
[2019-01-25 06:47:17,217] WARN The configuration 'producer.type' was supplied but isn't a known config. (org.apache.kafka.clients.producer.ProducerConfig:287)
[2019-01-25 06:47:17,217] WARN The configuration 'queue.buffering.max.messages' was supplied but isn't a known config. (org.apache.kafka.clients.producer.ProducerConfig:287)
[2019-01-25 06:47:17,218] WARN The configuration 'queue.buffering.max.ms' was supplied but isn't a known config. (org.apache.kafka.clients.producer.ProducerConfig:287)
[2019-01-25 06:47:17,218] WARN The configuration 'compression.codec' was supplied but isn't a known config. (org.apache.kafka.clients.producer.ProducerConfig:287)
[2019-01-25 06:47:17,218] WARN The configuration 'serializer.class' was supplied but isn't a known config. (org.apache.kafka.clients.producer.ProducerConfig:287)

I suggest updating this file

xhl1988 commented 5 years ago

@yangy0000 we need to fix the config. @rantav current master has only two unknown config, we will fix it soon

[2018-12-26 16:54:14,099] WARN The configuration 'producer.type' was supplied but isn't a known config. (org.apache.kafka.clients.producer.ProducerConfig)
[2018-12-26 16:54:14,099] WARN The configuration 'serializer.class' was supplied but isn't a known config. (org.apache.kafka.clients.producer.ProducerConfig)
xhl1988 commented 5 years ago

200

yangy0000 commented 5 years ago

uReplicator need to use "producer.type'', I'm going to leave this property there before I found a better place, but I fixed the rest of them